Fix filter #43
Merged
Fix filter #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter for `renovate[bot]` not `renovate`.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the release workflow’s author filters to target the Renovate bot specifically rather than any mention of “renovate.”
- Changed the filter from
@renovateto@renovate[bot]. - Ensures only Renovate bot commits are excluded.
- No other workflow behavior is altered.
Comments suppressed due to low confidence (2)
.github/workflows/release.yml:68
- [nitpick] Consider consolidating repeated
.filtercalls into a single pass that checks against an array of ignored bot usernames (e.g.,['costellobot', 'dependabot', 'github-actions', 'renovate[bot]']) to improve readability and reduce duplication.
.filter((line) => !line.includes(' @renovate[bot] '))
.github/workflows/release.yml:68
- Add or update a test for the release notes generator to confirm that lines mentioning
@renovate[bot]are filtered out while lines with other variations (e.g.,@renovate) remain.
.filter((line) => !line.includes(' @renovate[bot] '))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter for
renovate[bot]notrenovate.